Qcubed and Short Open Tags
Sun, 06/13/2010 - 02:06
Hello,
I thought you said Qcubed doesn't use short open tags / php_short_tags (as in <?= ?>). I was browsing through the examples of qcubed1.1.1 and each time I needed to view the source, it threw me errors stating that I am FORBIDDEN to view the page on my own LOCAL MACHINE. I did a bit if digging and made changes as follows:
Line 14: qcubed-1.1.1\assets\_core\php\examples\includes\header.inc.php
var objWindow = window.open(
"<?= __EXAMPLES__ ?>/view_source.php/" +
intCategoryId + "/" + intExampleId + fileNameSection,
"ViewSource","menubar=no,toolbar=no,location=no,status=no,
scrollbars=yes,resizable=yes,
width=1000,height=750,left=50,top=50");
objWindow.focus();I changed it to:
var objWindow = window.open(
"<?php _p(__EXAMPLES__); ?>/view_source.php/" +
intCategoryId + "/" + intExampleId + fileNameSection,
"ViewSource","menubar=no,toolbar=no,location=no,status=no,
scrollbars=yes,resizable=yes,
width=1000,height=750,left=50,top=50");
objWindow.focus();And VIOLA! I could view example sources rightaway. I also did a scan of all files using "search in folder" and discovered many other occurences of short open tags (apart from the ones in DATAGRIDS and similar controls, which we know are NOT actually php_short_tags).
Please kindly investigate this and correct them if they are mistakes.
This was addressed in Ticket 435. It should be fixed in 1.1 and 2.0.
Yeah, this is fixed in SVN, but 1.1.2 and 2.0.1 will be the first releases to include this fix.
Just a note that the framework itself is not using short tags, just the examples. And as you can see from the patch in that ticket, it's a quick, one-place change if you want to fix it in your copy as well.