Proposed Standards
Wed, 10/19/2011 - 15:59
Since all core contributers to QCubed qualify for a free copy of PHPStorm, and PHPStorm has some awesome validation and formatting features, perhaps we should standardize on them?
I'm thinking of two simple requirements:
1) All checked in files must be "green". This enforces good PHPDoc comments as well as avoiding most typos.
2) All checked in files must be auto-formatted using an agreed upon collection of settings. Which settings is a pretty minor concern to me, but having a standard will make patches more readable and less prone to unintended spacing changes.
Thoughts?
I fully and wholeheartedly agree. In fact PhpStorm's default formatting settings are pretty close to what we are using currently (except I think the indentation at the first level).
Let's also agree that changes to code that are purely for reasons of formatting or fixing yellow warnings or red errors do not need reviews from other core contributers, and can be checked in directly into trunk.