Assets constants core / user
Tue, 12/01/2009 - 21:02
Hey folks,
was beginning with a YAML CSS plugin and some questions come up.
In configuration.inc.php are the definitions for assets constants, 4 point to /assets/_core, where the developer never should put the files and 1 points to /assets/plugins.
So if a developer would have his images under /assets/images he can't use a constant, besides defining it self and I assume the _core assets definings would not used very often.
Wouldn't it be better to have additional defininig for
- assets/
and for developing with QCubed
- assets/images
- assets/css
- assets/fonts
- assets/js
- assets/php
define ('__ASSETS__', __SUBDIRECTORY__ . '/assets');
define ('__USER_CSS_ASSETS__', __ASSETS__ . '/css');
define ('__USER_FONTS_ASSETS__', __ASSETS__ . '/fonts');
define ('__USER_IMAGE_ASSETS__', __ASSETS__ . '/images');
define ('__USER_JS_ASSETS__', __ASSETS__ . '/js');
define ('__USER_PHP_ASSETS__', __ASSETS__ . '/php');
define ('__USER_PLUGIN_ASSETS__', __ASSETS__ . '/plugins');That could be more practical for a developer and could also be used by plugin manager.
What do you think?
This is discussed in http://trac.qcu.be/projects/qcubed/ticket/268
I wouldn't be against overturning the decision in ticket 268 and actually going with the proposal from this thread. If someone is passionate about to make a patch, we'll put it into the core.
Attached a patch for this ticket.