Whether it should go to the core or be a plugin depends on the simple question:

Is providing SEO support optional?

I wouldn't be in problem if it is left as a plugin but I would really prefer it to go into the core. Someone who did not discover the plugin on the site or was unable to download it for other reason would be in loss of a very important functionality. Also, functionality as such is really important to have for a development framework (in fact, I was surprised that it did not exist in QCubed at the first place).

I did try to make it like QPaginator so that it could be easy but I could not find out a way for that. The design goals are different. QPaginator is to simply Paginate and uses FormState. QLinkPaginator on the other hand is not dependent on the FormState for most of its work (save the drop down list and the 'Go' button). It relies on processing the URL and creation of links for 'next' and 'previous' pages is the main work here. It is made to handle nuisances with URL, which QPaginator does not (and should not) care about. So QPaginator-like behavior was not really possible. I did try out things what you said, like extending QPaginatorBase or making it drop-in replacement for QPaginator but they did not work out and also, as I said, the goals of these two paginators are different and no, please do not retire/replace QPaginator - its really a piece of beauty.

I made this paginator for my own selfish purpose - to allow SEO where required and to use QPaginator where I want to not let Google go too far and I believe it should be used that way. I would prefer it going to the core (and you could move a lot of 'setter' properties to the constructor call to save a little clutter) but making it a plugin does not offend me either (anyway, it is being used my me well enough :P )

Regards,
Vaibhav

As discussed in  http://qcu.be/content/qdatetime-timezone-issue

$strTime = '2005-05-05T11:05:24+0700'; print $strTime."\n"; // show that DateTime handles everything correctly $y = new Datetime($strTime); print $y->format(DateTime::ISO8601)." - DateTime\n"; // and QDateTime fails miserably $x = new QDatetime($strTime); print $x->format(DateTime::ISO8601)." - QDateTime\n";

This produces
<code>
2005-05-05T11:05:24+0700
2005-05-05T11:05:24+0700 - DateTime?
2005-05-04T21:05:24-0700 - QDateTime
</code>

fixed:

(In [1391]) code by vaibhav, modified and reviewed by vakopian. Fixes #770

code by vaibhav, modified and reviewed by vakopian. Fixes #770

(In [1390]) missed from ticket 766. Refs #766

As you guys may have noticed I made some minor changes (renamed the enum to QCrossScripting::HTMLPurifier etc). As agreed I changed the default mode back to legacy (Deny). I also reworked the example to account for that and added two more cases.

Alex feel free to change the wording in the example and elsewhere as you wish to emphasise the recommended way (either with this or with a separate ticket).

fixed:

(In [1389]) code by vaibhav, reviewed and modified by alex and vakopian. Fixes #766.

Thanks vaibhav,
Could this be used as a drop-in replacement for the existing QPaginator? If not, can it be made to be (i.e. extend QPaginatorBase)?

I can't quite decide if this is more appropriate as a plugin or as part of the core. It looks completely self-contained, so it might be a good candidate for a plugin.
Alex what do you think?

Either way, if you get a chance, it would help a lot to have an example for it.

code by vaibhav, reviewed and modified by alex and vakopian. Fixes #766.

fixed:

(In [1388]) reviewed by alex. Fixes #763

reviewed by alex. Fixes #763

(In [1387]) don't ignore the Time Zone when constructing based on a given type. Refs #757

don't ignore the Time Zone when constructing based on a given type. Refs #757

status changed

Good one, vakopian!

Great ideas, Vakopian. Wanna add that wording + config checker verification + check it in?

I'm travelling without my laptop :-(

Alex, would you like to add some wording to configuration.inc.php and maybe the warning in the config checker?
I could also commit this as is, and you can add that later. Whichever you prefer.

fixed:

(In [1386]) reviewed by alex. Fixes #767

reviewed by alex. Fixes #767

This has been broken by the move to jQuery, because $j(this).attr("type") does not return the type property of the DOM element (which is what was used prior to jQuery).
I don't think the proposed solution is the best solution since it would put a non-standard "type" attribute on the select tag.
It's much easier to fix qcubed.js.
Patch is attached, please test.